[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

frasertweedale freeipa-github-notification at redhat.com
Tue Dec 20 01:12:04 UTC 2016


  URL: https://github.com/freeipa/freeipa/pull/348
Title: #348: ca: fix ca-find with --pkey-only

frasertweedale commented:
"""
IMO the current change is fine, but I would also implement a defensive guard within `set_certificate_attrs` in case this somehow happens in some other command.

```python
def set_certificate_attrs(entry, options, want_cert=True):
    if 'ipacaid' not in entry:
        return
    ca_id = entry['ipacaid'][0]
    ...
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-268125375


More information about the Freeipa-devel mailing list