[Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

[Jan Cholasta]

On 2.2.2016 11:46, Jan Cholasta wrote:
> On 2.2.2016 11:41, Martin Babinsky wrote:
>> On 02/02/2016 09:33 AM, Jan Cholasta wrote:
>>> On 1.2.2016 14:54, Martin Basti wrote:
>>>>
>>>>
>>>> On 01.02.2016 13:55, Martin Babinsky wrote:
>>>>> https://fedorahosted.org/freeipa/ticket/5655
>>>>>
>>>>>
>>>>>
>>>>
>>>> LGTM, works for me, tested on both ca-less server and CA-full server.
>>>>
>>>> Because patch is touching certmonger I would like to get final ACK from
>>>> Honza.
>>>
>>> This is suspicious:
>>>
>>> -    if is_ca_enabled():
>>> -        http.configure_certmonger_renewal_guard()
>>> +    http.configure_certmonger_renewal_guard()
>>>
>>> Why is it necessary?
>>>
>>
>> I don't know, you tell me:
>> b9ae7690489368ead9f4983d386fa210dc265dfa
>
> What I meant is why is the change necessary, not why is the original
> code necessary.

Ah, the original code didn't have the condition. LGTM then.

-- 
Jan Cholasta