[Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

[Lukas Slebodnik]

On (29/01/16 19:59), Alexander Bokovoy wrote:
>On Fri, 29 Jan 2016, Lukas Slebodnik wrote:
>>On (29/01/16 12:12), Lukas Slebodnik wrote:
>>>ehlo,
>>>
>>>attached patch shoudl fix build on fedora-24.
>>>It blocks static analysis scan.
>>>
>>>Even though it unblock build on fedora-24
>>>the solution is not ideal. It's possible that some changes
>>>need to be done in samba side as well.
>>>(missing prototypes for trim_string, smb_xstrdup
>>>
>>>LS
>>
>>BTW there is also another issue in IPA-SAM.
>>The value of macro LDAP_PAGE_SIZE has changed
>>and therefore there is a warning.
>>
>>ipa_sam.c:114:0: warning: "LDAP_PAGE_SIZE" redefined
>>#define LDAP_PAGE_SIZE 1024
>>^
>>In file included from /usr/include/samba-4.0/smbldap.h:24:0,
>>                from ipa_sam.c:31:
>>/usr/include/samba-4.0/smb_ldap.h:81:0: note: this is the location of the previous definition
>>#define LDAP_PAGE_SIZE 1000
>This is something we should fix. I'll look at it once in Brno.
Here is a related change in samba
https://github.com/samba-team/samba/commit/8c2609f3186d40afb5954737dc174ce190cd368a

LS