[Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

[Milan Kubík]

On 02/11/2016 10:00 AM, Martin Babinsky wrote:
> On 02/09/2016 04:06 PM, Milan Kubík wrote:
>> On 02/09/2016 02:37 PM, Milan Kubík wrote:
>>> Fixes the CA ACL tests broken by removed import. This patch doesn't
>>> rely on undocumented behavior of pytest.
>>>
>>> The patch invalidates patch 133 by Martin Babinsky.
>>>
>>>
>>>
>> Patch updated with trac link
>>
>> -- 
>> Milan Kubik
>>
>>
>>
> ACK I guess, although copypasta makes me very sad.
>
> Why do you think the conftest.py approach is not practical for us?
>
I think introducing new file to hold shared fixtures is not worth 
managing it and it also hides (by the virtue of pytest's working) from 
where the fixture comes. I think it is better in our case to have all 
fixtures the test uses in its module, even though it looks like 
copy-pasting. If I had renamed the entry for the test only, would it 
still been considered copy-paste?

Anyway, patch for ipa-4-3 attached.


-- 
Milan Kubik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa43-0032-1-ipatests-Add-missing-certificate-profile-fixture.patch
Type: text/x-patch
Size: 1589 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160211/a02a7ae3/attachment.bin>