[Freeipa-devel] [patch 0032] ipatests: add missing certprofile fixture

[Martin Basti]

On 11.02.2016 14:12, Martin Babinsky wrote:
> On 02/11/2016 02:08 PM, Milan Kubík wrote:
>> On 02/11/2016 10:00 AM, Martin Babinsky wrote:
>>> On 02/09/2016 04:06 PM, Milan Kubík wrote:
>>>> On 02/09/2016 02:37 PM, Milan Kubík wrote:
>>>>> Fixes the CA ACL tests broken by removed import. This patch doesn't
>>>>> rely on undocumented behavior of pytest.
>>>>>
>>>>> The patch invalidates patch 133 by Martin Babinsky.
>>>>>
>>>>>
>>>>>
>>>> Patch updated with trac link
>>>>
>>>> -- 
>>>> Milan Kubik
>>>>
>>>>
>>>>
>>> ACK I guess, although copypasta makes me very sad.
>>>
>>> Why do you think the conftest.py approach is not practical for us?
>>>
>> I think introducing new file to hold shared fixtures is not worth
>> managing it and it also hides (by the virtue of pytest's working) from
>> where the fixture comes. I think it is better in our case to have all
>> fixtures the test uses in its module, even though it looks like
>> copy-pasting. If I had renamed the entry for the test only, would it
>> still been considered copy-paste?
>>
>> Anyway, patch for ipa-4-3 attached.
>>
>>
> ACK to both.

Pushed to master: 87ee451c7d9b311192893b2a2c82d8d757281fa6
Pushed to ipa-4-3: 8aec20124d415daeea3764294224fea47f8e7b0a