[Freeipa-devel] [PATCH] 0004 webui: topology graph: Add pan and zoom functionality

[Petr Vobornik]

On 02/03/2016 03:37 PM, Pavel Vomacka wrote:
> Hello,
>
> I'm sending a patch for review. This patch adds pan and zoom
> functionality to the topology graph. The page remembers old position and
> size of the graph. So, it keeps these settings after refreshing the page.
>
> The patch is in atachement.
>
> Pavel Vomacka
>
>

1. if node.fixed should be number then, we can store number in local 
storage as well(only as string, e.g. num + '') instead of 'true' so that 
we make the logic more straightforward/consistent.

2.  following lines are too long: .attr("transform", "translate(" + 
d3.event.translate + ")scale(" + d3.event.scale + ")");

.attr('transform', 'translate(' + trans.translate + ')scale(' + 
trans.scale + ')');

3. 'svg_' prefix for translate and scale keys is too generic, would use 
e.g. topo_graph

-- 
Petr Vobornik