[Freeipa-devel] [PATCH 0390] Fix build with GCC 4.9+

Petr Spacek pspacek at redhat.com
Thu Feb 25 14:57:51 UTC 2016


On 19.2.2016 13:55, Petr Spacek wrote:
> Hello,
> 
> Fix build with GCC 4.9+.
> 
> GCC 4.9+ is too aggressive when optimizing functions with nonnull
> attributes. This removes most of asserts() in the plugin.
> GCC 6 adds warnings for these cases.
> 
> We are disabling the unwanted condition pruning by adding
> -fno-delete-null-pointer-checks argument.
> BIND 9 did the same in its commit 603a78708343f063b44affb882ef93bb19a5142a.
> 
> Additionally we silence warnings to prevent build failures when -Werror
> is used.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1307346

Updated version is attached. It contains less autotools magic because it
enables attribute nonnull only under Clang static analyzer and Coverity - as a
result we do not have to silence GCC warnings from -Wnonnull.

Please review so I can fix build in Fedora 24.

Thank you.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0390-2-Fix-build-with-GCC-4.9.patch
Type: text/x-patch
Size: 2490 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160225/6e6a326c/attachment.bin>


More information about the Freeipa-devel mailing list