[Freeipa-devel] [PATCH 0401] ipa-adtrust-install: Allow dash in the NETBIOS name

[Martin Babinsky]

On 02/25/2016 02:13 PM, Tomas Babej wrote:
> Hi,
>
> Dash should be one of the allowed characters in the netbios names,
> so relax the too strict validation.
>
> Note: the set of allowed characters might expand in the future
>
> https://fedorahosted.org/freeipa/ticket/5286
>
> Tomas
>
>
>

NACK, since this patch breaks the interactive installation of adtrust, 
see the following log: http://fpaste.org/331088/56750906/

Keep in mind that the argument of any is first instantiated and then 
each element is tested. Since during interactive installation there is a 
possibility in the current code that check_netbios_name receives None as 
argument. You will have to correct this somehow.

-- 
Martin^3 Babinsky