[Freeipa-devel] [PATCH 0401] ipa-adtrust-install: Allow dash in the NETBIOS name

[Tomas Babej]

On 02/29/2016 03:20 PM, Martin Babinsky wrote:
> On 02/29/2016 02:59 PM, Tomas Babej wrote:
>>
>>
>> On 02/29/2016 02:04 PM, Martin Babinsky wrote:
>>> On 02/25/2016 02:13 PM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> Dash should be one of the allowed characters in the netbios names,
>>>> so relax the too strict validation.
>>>>
>>>> Note: the set of allowed characters might expand in the future
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/5286
>>>>
>>>> Tomas
>>>>
>>>>
>>>>
>>>
>>> NACK, since this patch breaks the interactive installation of adtrust,
>>> see the following log: http://fpaste.org/331088/56750906/
>>>
>>> Keep in mind that the argument of any is first instantiated and then
>>> each element is tested. Since during interactive installation there is a
>>> possibility in the current code that check_netbios_name receives None as
>>> argument. You will have to correct this somehow.
>>>
>>
>> Good catch. My original patch indeed breaks the interactive installation
>> on a clean machine where no netbios name has been specified explicitly.
>>
>> Fixed, attaching patches for both branches.
>>
>> Tomas
>>
> ACK
> 

Pushed to ipa-4-2: 657838462c4b0ce5be2cee584b3be112aca6c660
Pushed to ipa-4-3: 1496fb779d72fb590376df23e39206938fe8dad2
Pushed to master: b41fbceeafea126f8e014da5d3596138c6cf0feb