[Freeipa-devel] [PATCHES] 0772-0774 Python3 fixes in for client installation

[Petr Viktorin]

On 02/29/2016 08:12 AM, Jan Cholasta wrote:
> Hi,
> 
> On 26.2.2016 17:14, Petr Viktorin wrote:
>> On 02/22/2016 12:37 PM, Petr Viktorin wrote:
>>> Hello,
>>> These fixes are needed for the "happy path" of ipa-client-install
>>> --server on Python 3.
>>
>> Hello,
>> Could someone please look at these patches?
> 
> Patch 0772:
> 
> 1) Instead of decoding when the type is bytes in get_ipa_basedn(), read
> attribute values from 'entry.raw' rather than 'entry' and decode always.

Done.

> 2) get_ipa_basedn() is used only in ipadiscovery, perhaps we should move
> it there?

I did that in an extra patch, mainly to make the diff more meaningful.

> Patch 0773: ACK, but the patch does not apply on ipa-4-3.
> 
> 
> Patch 0774: ACK.



-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0771-Move-get_ipa_basedn-from-ipautil-to-ipadiscovery.patch
Type: text/x-patch
Size: 5126 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160229/7f582faf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0772-ipadiscovery-Decode-to-unicode-in-ipacheckldap-get_i.patch
Type: text/x-patch
Size: 2418 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160229/7f582faf/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0773-ipapython.sysrestore-Use-str-methods-instead-of-func.patch
Type: text/x-patch
Size: 2705 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160229/7f582faf/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0774-ipalib.x809-Accept-bytes-for-make_pem.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160229/7f582faf/attachment-0003.bin>