[Freeipa-devel] [PATCHES] 0753-0759

Petr Viktorin pviktori at redhat.com
Wed Jan 6 14:28:36 UTC 2016


Hello,

Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except
"no-absolute-import" (which seems redundant to me) and the ones in
contrib/RHEL4.

As for contrib/RHEL4, I found a mail [0] from 2013 saying it hasn't been
used for a long time and probably doesn't work. Since then it's for
example been changed to use ipapython.dn, which I'd bet no one checks
for Python 2.5 compatibility. Since this seems to be untested and
non-working code, so I'm sending a patch to remove it. But if that's not
wanted tell me, and I'll skip pylint --py3k checks there instead.

The last patch adds py3k lint check  to make-lint. It's a bit
cumbersome, since pylint doesn't allow running regular checkers and the
py3k ones at the same time, but it allows you to run the check. As for
whether to enable --py3k by default, or run it on every package build,
I'd like to defer the decision to core devs. (Is CI good enough nowadays
to only run it there?)


[0] https://www.redhat.com/archives/freeipa-users/2013-July/msg00055.html

-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0753-Don-t-index-exceptions-directly.patch
Type: text/x-patch
Size: 2547 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0754-Use-print_function-future-definition-wherever-print-.patch
Type: text/x-patch
Size: 1399 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0755-Alias-unicode-to-str-under-Python-3.patch
Type: text/x-patch
Size: 5479 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0756-Avoid-builtins-that-were-removed-in-Python-3.patch
Type: text/x-patch
Size: 2493 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0757-dnsutil-Rename-__nonzero__-to-__bool__.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0758-Remove-contrib-RHEL4.patch
Type: text/x-patch
Size: 37343 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0759-make-lint-Allow-running-pylint-py3k-to-detect-Python.patch
Type: text/x-patch
Size: 4062 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160106/24eeb8d1/attachment-0006.bin>


More information about the Freeipa-devel mailing list