[Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

Petr Viktorin pviktori at redhat.com
Fri Jan 8 11:45:45 UTC 2016


On 01/06/2016 03:28 PM, Petr Viktorin wrote:
> Hello,
> 
> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except
> "no-absolute-import" (which seems redundant to me) and the ones in
> contrib/RHEL4.

> The last patch adds py3k lint check  to make-lint. It's a bit
> cumbersome, since pylint doesn't allow running regular checkers and the
> py3k ones at the same time, but it allows you to run the check. As for
> whether to enable --py3k by default, or run it on every package build,
> I'd like to defer the decision to core devs. (Is CI good enough nowadays
> to only run it there?)
> 
> 
> [0] https://www.redhat.com/archives/freeipa-users/2013-July/msg00055.html

Here's a new version of the patchset, updated to current master.
The last patch requires 0758 (removing contrib/RHEL4) which is being
reviewed in another thread.

-- 
Petr Viktorin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0752.2-Use-explicit-truncating-division.patch
Type: text/x-patch
Size: 4884 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0753.2-Don-t-index-exceptions-directly.patch
Type: text/x-patch
Size: 2547 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0754.2-Use-print_function-future-definition-wherever-print-.patch
Type: text/x-patch
Size: 1892 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0755.2-Alias-unicode-to-str-under-Python-3.patch
Type: text/x-patch
Size: 5479 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0756.2-Avoid-builtins-that-were-removed-in-Python-3.patch
Type: text/x-patch
Size: 2493 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0757.2-dnsutil-Rename-__nonzero__-to-__bool__.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0759.2-make-lint-Allow-running-pylint-py3k-to-detect-Python.patch
Type: text/x-patch
Size: 4062 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160108/9b170f78/attachment-0006.bin>


More information about the Freeipa-devel mailing list