[Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

[Martin Basti]

On 11.01.2016 12:01, Milan Kubík wrote:
> On 01/07/2016 10:37 AM, Martin Basti wrote:
>>
>>
>> On 07.01.2016 10:23, Milan Kubík wrote:
>>> On 01/07/2016 09:31 AM, Oleg Fayans wrote:
>>>> Hi Milan,
>>>>
>>>> As we are eventialy going to move to python3, I would make the code
>>>> python3-compatible:
>>>>
>>>> 1. from __future__ import unicode_literals
>>>> 2. get rid of all u's in front of the strings
>>>>
>>>> On the other hand, we can make a separate commit with only py3-related
>>>> changes.
>>>>
>>>> On 01/07/2016 09:26 AM, Milan Kubík wrote:
>>>>> Fixes problems in tests uncovered by dns check introduced in ipa 4.3
>>>>>
>>>>>
>>>>>
>>> I don't think this patch is the right one to do this. I'd rather 
>>> convert the whole module in a separate patch.
>>>
>> Python 3.3+ support 'u' literals again 
>> https://docs.python.org/3.3/whatsnew/3.3.html
> So the best course of action here is?
>
Leave the patch as it is now, LGTM.
I just need to run tests if it really works.