[Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

[Petr Viktorin]

On 01/11/2016 02:49 PM, Martin Basti wrote:
> 
> 
> On 08.01.2016 12:45, Petr Viktorin wrote:
>> On 01/06/2016 03:28 PM, Petr Viktorin wrote:
>>> Hello,
>>>
>>> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except
>>> "no-absolute-import" (which seems redundant to me) and the ones in
>>> contrib/RHEL4.
>>> The last patch adds py3k lint check  to make-lint. It's a bit
>>> cumbersome, since pylint doesn't allow running regular checkers and the
>>> py3k ones at the same time, but it allows you to run the check. As for
>>> whether to enable --py3k by default, or run it on every package build,
>>> I'd like to defer the decision to core devs. (Is CI good enough nowadays
>>> to only run it there?)
>>>
>>>
>>> [0] https://www.redhat.com/archives/freeipa-users/2013-July/msg00055.html
>> Here's a new version of the patchset, updated to current master.
>> The last patch requires 0758 (removing contrib/RHEL4) which is being
>> reviewed in another thread.

Rebased to current master.


> Hello I tried --py3k option and it doesn't print any error, can we
> enable that check by default to prevent python3 regressions?
> 
> # ./make-lint --py3k
> No config file found, using default configuration

Squash in the other attached patch to enable it by default.

> Otherwise code LGTM and works for me, Honza will give you the final ack.


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0752.3-Use-explicit-truncating-division.patch
Type: text/x-patch
Size: 4884 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0753.3-Don-t-index-exceptions-directly.patch
Type: text/x-patch
Size: 2547 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0754.3-Use-print_function-future-definition-wherever-print-.patch
Type: text/x-patch
Size: 1892 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0755.3-Alias-unicode-to-str-under-Python-3.patch
Type: text/x-patch
Size: 5479 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0756.3-Avoid-builtins-that-were-removed-in-Python-3.patch
Type: text/x-patch
Size: 1743 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0757.3-dnsutil-Rename-__nonzero__-to-__bool__.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0759.3-make-lint-Allow-running-pylint-py3k-to-detect-Python.patch
Type: text/x-patch
Size: 4062 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUASH-Run-pylint-py3k-by-default.patch
Type: text/x-patch
Size: 1131 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160112/b8daf831/attachment-0007.bin>