[Freeipa-devel] [PATCHES] 0752-0757, 0759 Enable pylint --py3k

[Petr Viktorin]

On 01/19/2016 08:45 AM, Jan Cholasta wrote:
> On 14.1.2016 18:29, Petr Viktorin wrote:
>> On 01/12/2016 03:44 PM, Petr Viktorin wrote:
>>>
>>>>> Hello I tried --py3k option and it doesn't print any error, can we
>>>>> enable that check by default to prevent python3 regressions?
>>>>>
>>>>> # ./make-lint --py3k
>>>>> No config file found, using default configuration
>>>>
>>>> Squash in the other attached patch to enable it by default.
>>>
>>> Sorry, please ignore the squash patch -- if --py3k is to be on by
>>> default, I'll also need to add all needed packages to BuildRequires.
>>
>> Actually, after all, that's not true -- the py3 libraries aren't needed
>> for pylint --py3k.
>> So, patches are ready for review as they are (with your choice of what
>> the default should be).
> 
> Patch 759:
> 
> 1) Typo: 'Skil the main lint check'.

Will fix in the next patches.

> 2) Why the indentation change in output?

Fixed. I'm attaching the changed patch only.

> Regarding --(no-)py3k, do we even need the option? I would just enable
> the checks and not add the option unless someone specifically asked for it.

Several times I was annoyed how hard it is to use IPA's make-lint if you
need to do something other than lint the whole codebase with the default
options. (Usually what I end up doing is copying make-lint and patching
the copy to do what I want.)

I don't want to add to the annoyance by making it impossible to run just
one of the checks. So consider me asking for this :)

> Otherwise LGTM, including patch 758. 

Attaching updated patches, with py3k check as as default squashed in.
I also added a pylint exception for a new use of reload() in 0756.
One more thing I did was disable pylint's long and uninteresting report,
so now only the messages are shown.

-- 
Petr Viktorin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0752.4-Use-explicit-truncating-division.patch
Type: text/x-patch
Size: 4884 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0753.4-Don-t-index-exceptions-directly.patch
Type: text/x-patch
Size: 2547 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0754.4-Use-print_function-future-definition-wherever-print-.patch
Type: text/x-patch
Size: 1892 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0755.4-Alias-unicode-to-str-under-Python-3.patch
Type: text/x-patch
Size: 5479 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0756.4-Avoid-builtins-that-were-removed-in-Python-3.patch
Type: text/x-patch
Size: 2269 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0757.4-dnsutil-Rename-__nonzero__-to-__bool__.patch
Type: text/x-patch
Size: 1052 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0758.4-Remove-deprecated-contrib-RHEL4.patch
Type: text/x-patch
Size: 37336 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0759.4-make-lint-Allow-running-pylint-py3k-to-detect-Python.patch
Type: text/x-patch
Size: 3714 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0760.4-Split-ipa-client-into-ipaclient-Python-library-and-c.patch
Type: text/x-patch
Size: 714262 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160119/f1e86070/attachment-0008.bin>