[Freeipa-devel] [PATCH 0022] topology plugin prevents deletes but does not prevent moddn

[Martin Basti]

On 21.01.2016 11:35, thierry bordaz wrote:
> On 01/21/2016 11:26 AM, Ludwig Krispenz wrote:
>>
>> On 01/21/2016 11:21 AM, thierry bordaz wrote:
>>> On 01/21/2016 10:48 AM, Ludwig Krispenz wrote:
>>>>
>>>> On 01/21/2016 10:30 AM, thierry bordaz wrote:
>>>>> Hi,
>>>>>
>>>>> The fix look good.
>>>>> Just a question, the target entry is checked with 
>>>>> ipa_topo_check_entry_type. Is it equivalent to call 
>>>>> ipa_topo_is_entry_managed ?
>>>> no, ipa_topo_check_entry_type() just determines if it is a segment, 
>>>> a host, to decide how to proceed. ipa_topo_is_entry_managed() would 
>>>> apply to an replication agreement to decide if both endpoints are 
>>>> managed servers ant that the suffix is managed
>>>
>>> Ok thanks. In fact it does not apply to replica agreements.
>>> It allows the modrdn to 'cn=masters' subtree. Is this subtree part 
>>> of the topology config ?
>> no, it is probably not a good idea to move a master to another 
>> subtree, but it is not the task of the topology plugin to prevent this
>
> Right. Thanks for all your explanations and patience. THe fix is good 
> to me as well. Ack
>
> thierry

Thanks

Pushed to:
master: c152e1007515f208b0c3b84c1ff13a9fe9b45fdf
ipa-4-3: d8bfe61e3d71640fac8b5a2ca3c1107bf6aa83f3

>>>>>
>>>>> thanks
>>>>> thierry
>>>>> On 01/21/2016 09:11 AM, Ludwig Krispenz wrote:
>>>>>>
>>>>>> On 01/20/2016 05:45 PM, Martin Basti wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 11.12.2015 13:56, Ludwig Krispenz wrote:
>>>>>>>> Ticket: https://fedorahosted.org/freeipa/ticket/5536
>>>>>>>>
>>>>>>>> Patch attached.
>>>>>>>>
>>>>>>>>
>>>>>>> Patch works, I cannot move entry out of container via moddn 
>>>>>>> operation.
>>>>>>>
>>>>>>>
>>>>>>> I have question, is it expected to be able rename entry?
>>>>>>> I tried it and I was able to change RDN
>>>>>> yes, that should be fine, it cannot change the connectivity.
>>>>>>>
>>>>>>> #!RESULT OK
>>>>>>> #!CONNECTION ldap://vm-058-138.abc.idm.lab.eng.brq.redhat.com:636
>>>>>>> #!DATE 2016-01-20T16:28:18.702
>>>>>>> dn: 
>>>>>>> cn=vm-058-137.abc.idm.lab.eng.brq.redhat.com-to-vm-058-138.abc.idm.lab.eng
>>>>>>>  .brq.redhat.com,cn=domain,cn=topology,cn=ipa,cn=etc,dc=dom-138,dc=abc,dc=idm,
>>>>>>>  dc=lab,dc=eng,dc=brq,dc=redhat,dc=com
>>>>>>> changetype: moddn
>>>>>>> newrdn: 
>>>>>>> cn=vm-058-137.abc.idm.lab.eng.brq.redhat.com-to-vm-058-138.abc.idm.lab
>>>>>>>  .eng.brq.redhat
>>>>>>> deleteoldrdn: 1
>>>>>>> newsuperior: 
>>>>>>> cn=domain,cn=topology,cn=ipa,cn=etc,dc=dom-138,dc=abc,dc=idm,dc=l
>>>>>>>  ab,dc=eng,dc=brq,dc=redhat,dc=com
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160121/f24a95d9/attachment.htm>