[Freeipa-devel] [PATCH 0130] disable RA plugins when promoting a replica from CA-less master

[Martin Babinsky]

On 01/21/2016 02:51 PM, Jan Cholasta wrote:
> On 21.1.2016 14:45, Martin Babinsky wrote:
>> On 01/21/2016 02:21 PM, Petr Vobornik wrote:
>>> On 01/21/2016 01:53 PM, Martin Babinsky wrote:
>>>> this patch ensures that promoted replicas in CA-less topology have
>>>> correct settings in their default.conf.
>>>>
>>>> I couldn't find any ticket for this issue, should I file one so that
>>>> this patch can land in 4-3 branch?
>>>>
>>>
>>> yes
>>
>> New ticket here: https://fedorahosted.org/freeipa/ticket/5626
>>
>> I have also attached the ticket URL to the commit message.
>
> Why so much code for such a simple change? Please keep the style
> consistent with the code in install.install() and replicainstall.install().
>

It did not occur to me as much code, the logic was equivalent to the 
stuff other installers do but bit more concise.

But attaching updated patch in common style anyway.

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0130.2-disable-RA-plugins-when-promoting-a-replica-from-CA-.patch
Type: text/x-patch
Size: 2151 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160121/7ec95f7e/attachment.bin>