[Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

Tomas Babej tbabej at redhat.com
Thu Jan 28 14:20:46 UTC 2016



On 01/27/2016 03:58 PM, Martin Babinsky wrote:
> On 01/18/2016 06:43 PM, Martin Babinsky wrote:
>> A little patch that should make some future pylint errors disappear.
>>
>>
>>
> Attaching updated patch that does not promote direct molestation of
> instance dictionaries.
> 
> 
> 

Patch looks good, one thing I am concerened about though is that
__todict__ now returns a direct reference to the internal, mutable dict,
and no longer a (shallow) copy.

Maybe we should use dict.copy() there?

Tomas




More information about the Freeipa-devel mailing list