[Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

[Pavel Vomacka]

On 01/28/2016 07:28 PM, Petr Vobornik wrote:
> Hi, there are few issues, NACK.
>
> 1. this patch uses tabs instead of spaces, previous was correct
Fixed.
>
> 2. code which focuses first invalid field could be replaced by:
>   widget_mod.focus_invalid(that);
The old loop is replaced by this method.
>
> 3. there is a convention that field and widget names uses the same 
> name as the param, therefore 'textarea_cert' should be 'csr'. There is 
> no convention for messages in html widget but it might be better to 
> use a name reflecting purpose and not implementation. Instead of 
> 'message_html_widget' use 'instructions' or just 'message' - 
> consistent with spec option.
>
Fixed. I chose 'message' instead of 'message_html_widget'.
> Also I've filed: https://fedorahosted.org/freeipa/ticket/5652
Pavel Vomacka

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0003-3-Add-validation-to-Issue-new-certificate-dialog.patch
Type: text/x-patch
Size: 4426 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160129/99c221a5/attachment.bin>