[Freeipa-devel] [PATCH 0058] Make get_entries not ignore its size_limit argument

[Stanislav Laznicka]

Hello,

This patch fixes https://fedorahosted.org/freeipa/ticket/5640.

With not so much experience with the framework, it raises question in my 
head whether ipaldap.get_entries is used properly throughout the system 
- does it always assume that it gets ALL the requested entries or just a 
few of those as configured by the 'ipaSearchRecordsLimit' attribute of 
ipaConfig.etc which it actually gets?

One spot that I know the get_entries method was definitely not used 
properly before this patch is in the 
baseldap.LDAPObject.get_memberindirect() method:

  692             result = self.backend.get_entries(
  693                 self.api.env.basedn,
  694                 filter=filter,
  695                 attrs_list=['member'],
  696                 size_limit=-1, # paged search will get everything 
anyway
  697                 paged_search=True)

which to me seems kind of important if the environment size_limit is not 
set properly :) The patch does not fix the non-propagation of the 
paged_search, though.

Cheers,
Standa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-slaznick-0058-Make-get_entries-not-ignore-size_limit-argument.patch
Type: text/x-patch
Size: 2511 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160714/db1c39af/attachment.bin>