[Freeipa-devel] [PATCH 0183] ipa-advise: correct handling of plugin namespace iteration

Martin Babinsky mbabinsk at redhat.com
Tue Jul 19 07:15:19 UTC 2016


On 07/18/2016 08:46 AM, Jan Cholasta wrote:
> Hi,
>
> On 11.7.2016 14:18, Martin Babinsky wrote:
>> https://fedorahosted.org/freeipa/ticket/6044
>
> Note that you should use .name rather than .__name__ to get plugin
> names, otherwise the code won't work with plugins with non-default names.
>
> There currently aren't any Advice plugins with non-default name, but I
> would rather fix this now to avoid surprises later.
>
> Honza
>

I didn't realize this when doing the patch, here's the fix for that.

I have attached the original closed ticket to the commit message, should 
I create a new ticket for such a small change?

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0191-advise-Use-name-instead-of-__name__-to-get-plugin-na.patch
Type: text/x-patch
Size: 1323 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160719/6e3f1db1/attachment.bin>


More information about the Freeipa-devel mailing list