[Freeipa-devel] [PATCH] 963 unite log file name of ipa-ca-install

[Petr Vobornik]

On 07/19/2016 08:01 AM, Jan Cholasta wrote:
> Hi,
> 
> On 18.7.2016 18:50, Florence Blanc-Renaud wrote:
>> On 07/15/2016 04:29 PM, Petr Vobornik wrote:
>>> ipa-ca-install said that it used
>>>   /var/log/ipareplica-ca-install.log
>>> but in fact it used
>>>   /var/log/ipaserver-ca-install.log
>>>
>>> This patch unites it to ipaserver-ca-install.log
>>>
>>> It was chosen because ipa-ca-install can be also used on
>>> master on CA-less -> CA conversion.
>>>
>>> Term "server" is valid for both master and replica.
>>>
>>> https://fedorahosted.org/freeipa/ticket/6088
>>>
>>>
>>>
>>
>> Looks good to me.
>> Ack
> 
> Does not look so good to me, "ipareplica-ca-install.log" is in fact the
> original file name used since ipa-ca-install was introduced (in commit
> 8a32bb3746802a29b2655e4ad2cbbba8481e1eaf), so why the switch to
> "ipaserver-ca-install.log"?
> 
> Honza
> 

Ideally it would be ipa-ca-install.log but for backwards compatibility,
let's stick with one which we have. AFAIK the framework(run_script
methodú doesn't support switching the log name which is printed in error
message depending on usage. Therefore the universal was chosen -
ipaserver-ca-install.log. It was introduced by your commit
d27e77adc56f5a04f3bdd1aaed5440a89ed3acad

And I see, that I used wrong ticket number in the commit. Correct is
https://fedorahosted.org/freeipa/ticket/6086

Proper solution might be to rework main and __main__ function in
ipa-ca-install but IMO we spent too much time on this already.
-- 
Petr Vobornik