[Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests

[Ganna Kaihorodova]

Hello!

Thank you for review. 
I attached patch with fixed commit message


Best regards,
Ganna Kaihorodova
Associate Software Quality Engineer


----- Original Message -----
From: "Martin Basti" <mbasti at redhat.com>
To: "Ganna Kaihorodova" <gkaihoro at redhat.com>, freeipa-devel at redhat.com
Sent: Wednesday, July 20, 2016 5:04:47 PM
Subject: Re: [Freeipa-devel] [PATCH 0002][Tests] Small fix for dns_plugin tests



On 20.07.2016 17:02, Ganna Kaihorodova wrote:
> Greetings!
>
> Fix for ipatests/test_xmlrpc/test_dns_plugin.py
>
> Fix conflict between “got” and “expected” values when testing "dnsconfig_mod: Update global DNS settings"
>
> Best regards,
> Ganna Kaihorodova
> Associate Software Quality Engineer
>
>
>
>
LGTM, but can you fix commit message?

This looks very suspicious

Subject: [PATCH 2/2] =?UTF-8?q?Fix=20conflict=20between=20=E2=80=9Cgot?=
  =?UTF-8?q?=E2=80=9D=20and=20=E2=80=9Cexpected=E2=80=9D=20values=20when=20?=
  =?UTF-8?q?testing=20"dnsconfig=5Fmod:=20Update=20global=20DNS=20settings"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


regards,
Martin^2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-gkaihoro-0002-Fix-conflict-between-got-and-expected-values.patch
Type: text/x-patch
Size: 1312 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160720/6e2b7fc8/attachment.bin>