[Freeipa-devel] [PATCH 190] expose `--secret` option in radiusproxy-* commands

[Martin Babinsky]

On 07/20/2016 12:10 PM, Martin Babinsky wrote:
> On 07/19/2016 12:32 PM, Jan Cholasta wrote:
>> Hi,
>>
>> On 18.7.2016 13:51, Martin Babinsky wrote:
>>> https://fedorahosted.org/freeipa/ticket/6078
>>
>> I don't think we want the secret searchable. Add a 'no_search' flag to
>> the param to fix that.
>>
>> Honza
>>
>
> 'no_search' flag breaks the API backwards compatibility, so I am sending
> another two patches which fix handling of deprecated options in the
> framework and deprecate `--secret` in radiusproxy-find command.
>
> I hope this solution is the best.
>
>
>
After discussion with Jan we realized that it is enough to hide the 
'--secret' option from CLI, not deprecate it.

Re-sending patch 190 and updated 193.1. Patch 192 will be send in 
separate thread since the actual issue it fixes is orthogonal to this 
one and requires a separate ticket.

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0190-expose-secret-option-in-radiusproxy-commands.patch
Type: text/x-patch
Size: 1147 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160721/d37833f3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0193.1-prevent-search-for-RADIUS-proxy-servers-by-secret.patch
Type: text/x-patch
Size: 1256 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160721/d37833f3/attachment-0001.bin>