[Freeipa-devel] [PATCH 0488-0489] Perfomance: membership processing related patches

[Martin Basti]

On 31.05.2016 14:10, Martin Basti wrote:
>
>
> On 31.05.2016 14:08, Martin Babinsky wrote:
>> On 05/31/2016 01:57 PM, Martin Basti wrote:
>>>
>>>
>>> On 31.05.2016 12:44, Martin Babinsky wrote:
>>>> On 05/28/2016 01:17 PM, Martin Basti wrote:
>>>>> https://fedorahosted.org/freeipa/ticket/4995
>>>>>
>>>>> Patches attached
>>>>>
>>>>>
>>>>>
>>>>
>>>> Hi,
>>>>
>>>> PATCH 0488: LGTM
>>>>
>>>> PATCH 0489:
>>>>
>>>> @@ -996,10 +997,10 @@ def check_deleted_segments(hostname, masters,
>>>> topo_errors, starting_host):
>>>>          i = 0
>>>>          while True:
>>>>              left = api.Command.topologysegment_find(
>>>> -                suffix_name, iparepltoposegmentleftnode=hostname,
>>>> sizelimit=0
>>>> +                suffix_name, iparepltoposegmentleftnode=hostname,
>>>> sizelimit=0,
>>>>              )['result']
>>>>              right = api.Command.topologysegment_find(
>>>> -                suffix_name, iparepltoposegmentrightnode=hostname,
>>>> sizelimit=0
>>>> +                suffix_name, iparepltoposegmentrightnode=hostname,
>>>> sizelimit=0,
>>>>              )['result']
>>>>
>>>> it seems that you added 'no_members=True' there and then removed it
>>>> because reasons. Please revert the this part to the original code so
>>>> that it does not stick out.
>>>>
>>>
>>> Better (the right one) patches attached.
>>
>> ACK
>>
> master:
> * 91572afc60f590f0d81ad18234189a0b48144bf5 Make option --no-members 
> public in CLI
> * 5f42b42bd4557a669ab5cfcf1af6596f1a2535f1 Performance: Find commands: 
> do not process members by default
>

We found and issue, I used flag 'no_cli' instead of 'no_option'

fixed and pushed under oneliner rule

master:
* 5c58751d72de27eae2181f2c0e620df03f8dbc82 Fix: replace incorrect no_cli 
with no_option flag


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0493-Fix-replace-incorrect-no_cli-with-no_option-flag.patch
Type: text/x-patch
Size: 1216 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160602/f29b2436/attachment.bin>