[Freeipa-devel] [PATCH] 0002 New User Role Tests

[Peter Lacko]

Sorry for late response, I wasn't working these days.
Fixed patch is in attachment.

Peter


----- Original Message -----
From: "Martin Basti" <mbasti at redhat.com>
To: "Peter Lacko" <placko at redhat.com>, freeipa-devel at redhat.com
Sent: Monday, May 9, 2016 1:06:08 PM
Subject: Re: [Freeipa-devel] [PATCH] 0002 New User Role Tests



On 09.05.2016 13:04, Martin Basti wrote:
>
>
> On 09.05.2016 12:19, Peter Lacko wrote:
>> +# pylint: disable=unicode-builtin
> I'm not doing complete review, just the line above hit my eyes.
>
> unicode() is not in Py3 because all strings there are unicode, thus 
> you cannot use it directly, you need something like
>
> if six.PY2:
>     str = unicode
>
> and use str() everywhere and remove that #pylint line
>
> FYI all enabled pylint checks are there for a good reason, be careful 
> with disabling it (mainly disabling it for a whole module) rather ask 
> before if you are not sure.
>
> Martin^2
>

Nope, sorry, I temporarily forgot how to python

instead of pylint disable use this

if six.PY3:
     unicode =str

and keep unicode there. Sorry

Martin^2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-placko-0002-2-New-User-Role-Tests.patch
Type: text/x-patch
Size: 68003 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160602/60bd5f4f/attachment.bin>