[Freeipa-devel] [PATCH 0033] Fix CA being presented as running even if it weren't

Martin Basti mbasti at redhat.com
Thu Jun 2 17:21:32 UTC 2016



On 31.05.2016 16:32, Stanislav Laznicka wrote:
> On 05/31/2016 11:40 AM, Stanislav Laznicka wrote:
>> On 05/31/2016 10:22 AM, Stanislav Laznicka wrote:
>>> On 05/30/2016 12:54 PM, Jan Cholasta wrote:
>>>> On 30.5.2016 12:36, Martin Basti wrote:
>>>>>
>>>>>
>>>>> On 26.05.2016 19:31, Stanislav Laznicka wrote:
>>>>>>
>>>>>> Self NACK. I should not post patches when tired, sorry. Minor fix is
>>>>>> attached.
>>>>>>
>>>>>>
>>>>>> On 05/26/2016 07:21 PM, Stanislav Laznicka wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Please, see the attached patch. Fixes
>>>>>>> https://fedorahosted.org/freeipa/ticket/5898
>>>>>>>
>>>>>>> Standa
>>>>>>>
>>>>>>
>>>>>
>>>>> LGTM, if nobody is against this, I will push it in 2 days
>>>>
>>>> NACK, please add `wait` argument and call 
>>>> self.wait_until_running(), same as in start() and restart().
>>>>
>>> A pretty good point, please see the modified patch.
>> Self.NACK - can't add 'wait' agrument to service.Service.is_running 
>> this easy.
>>
> Should be fixed now.


works for me, can be pushed if Honza agree

Martin^2




More information about the Freeipa-devel mailing list