[Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

[Martin Basti]

On 03.06.2016 08:53, Petr Spacek wrote:
> On 2.6.2016 17:53, Martin Basti wrote:
>> <snip>
>>>>>>> Typo - redundant ' ' at the end.
>>>>>>>
>>>>>>>
>>>>>>> Conditional NACK, warnings mentioned in
>>>>>>> http://www.freeipa.org/page/V4/DNS_Location_Mechanism#CLI
>>>>>>> are not there.
>>>>>>>
>>>>>>> I'm open to changing this to ACK if you open a separate ticket for this
>>>>>>> omission so we do not forget to add them later on.
>> I forgot to add, this will be in next batch of patches (you may see that there
>> are not marked DNS servers in output of location show), I do not see reason to
>> open ticket when the current one is not finished.
>>
>>>>>> +1
>>>>>>
>>> Done
>>>
>>>>>> Patch 480:
>>>>>>
>>>>>> 1) The code in location_show.execute() looks like it could be moved to
>>>>>> location_show.post_callback()
>>>>>>
>>> I had to add it to execute because I modifies result entry not just entry_attrs
>>>
>>>>>> 2) Before calling super().output_for_cli(), pop 'servers' from result, so
>>>>>> that
>>>>>> it is not displayed with --all.
>>>>>>
>>>>>>
>>> Done
>>>
>>>>>> Patch 481:
>>>>>>
>>>>>> 1) Could we rename --force to --nonempty (or something better)? I would like
>>>>>> to reserve --force for "ignore NotFound when deleting the entry", which
>>>>>> is not
>>>>>> the case here.
>>>>> IMHO option is unnecessary. Just delete the location (and unset location from
>>>>> all member servers). The design does not contain --force anyway :-)
>>>> OK, that's even better :-)
>>>>
>>> Done
>>>
>>> Updated patches attached
> I had to add top object class to the plugin and tests to make tests pass.
> Patch is attached.
>
> CondACK: Fix this before pushing somehow.
>

Updated and heavily rebased patches attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0473.8-DNS-Locations-Always-create-DNS-related-privileges.patch
Type: text/x-patch
Size: 4774 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0474.8-DNS-Locations-add-new-attributes-and-objectclasses.patch
Type: text/x-patch
Size: 4186 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0475.8-DNS-Locations-location-commands.patch
Type: text/x-patch
Size: 12819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0476.8-DNS-Locations-API-tests.patch
Type: text/x-patch
Size: 9339 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0478.8-Allow-to-use-non-Str-attributes-as-keys-for-members.patch
Type: text/x-patch
Size: 2162 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0479.8-DNS-Locations-extend-server-command-with-locations.patch
Type: text/x-patch
Size: 9419 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0480.8-DNS-Location-location-show-return-list-of-servers-in.patch
Type: text/x-patch
Size: 9287 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0481.8-DNS-Locations-when-removing-location-remove-it-from-.patch
Type: text/x-patch
Size: 1871 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0482.8-DNS-Locations-extend-tests-with-server-commands.patch
Type: text/x-patch
Size: 13450 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160603/e45f3605/attachment-0008.bin>