[Freeipa-devel] [PATCH] 0005 Always qualify requests for admin in ipa-replica-conncheck

[Martin Basti]

On 02.06.2016 14:58, Florence Blanc-Renaud wrote:
>
> Hi,
>
> this patch modifies ipa-replica-conncheck when it performs the SSH 
> connection to the master, so that the username is always fully qualified.
>
> https://fedorahosted.org/freeipa/ticket/5812
> -- 
> Florence Blanc-Renaud
> Identity Management Team, Red Hat
>
>

LGTM, but because current issues with replica install in master branch, 
I couldn't test it and I would like to be sure that ipa-replica-install 
using NTP will work too


Just little nitpick, for better readibility, 'command' should be on new line
-            '%s@%s' % (self.user, self.addr), command
+            '-o User=%s' % self.user,
+            '%s' % self.addr, command

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160606/549119b0/attachment.htm>