[Freeipa-devel] [WIP] Thin client

[Jan Cholasta]

On 9.6.2016 08:14, David Kupka wrote:
> On 08/06/16 14:44, Jan Cholasta wrote:
>> On 8.6.2016 14:40, Martin Babinsky wrote:
>>> On 06/08/2016 02:11 PM, David Kupka wrote:
>>>> On 28/04/16 14:45, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> I have pushed my thin client WIP branch to GitHub:
>>>>> <https://github.com/jcholast/freeipa/tree/trac-4739>.
>>>>>
>>>>> All commits up to "ipalib: use relative imports for cross-plugin
>>>>> imports" should be good for review. The rest is subject to change
>>>>> (WARNING: I will force push into this branch).
>>>>>
>>>>> Honza
>>>>>
>>>>
>>>> Hello!
>>>>
>>>> Patch set:
>>>>
>>>> spec file: require correct packages to get API plugins
>>>> schema: fix typo
>>>> schema: fix topic command output
>>>> replica install: use remote server API to create service entries
>>> This one is not complete since it breaks replica install w/ --setup-dns.
>>> Removing this line seems to fix this case:
>>>
>>> """
>>> diff --git a/ipaserver/install/server/replicainstall.py
>>> b/ipaserver/install/server/replicainstall.py
>>> index 41eee96..d695a15 100644
>>> --- a/ipaserver/install/server/replicainstall.py
>>> +++ b/ipaserver/install/server/replicainstall.py
>>> @@ -1478,7 +1478,6 @@ def promote(installer):
>>>      server_api.finalize()
>>>
>>>      if options.setup_dns:
>>> -        server_api.Backend.rpcclient.connect()
>>>          server_api.Backend.ldap2.connect(autobind=True)
>>>          dns.install(False, True, options, server_api
>>> """
>>
>> Fixed.
>>
>>>
>>>
>>>> schema: do not validate unrequested params in command_defaults
>>>>
>>>> fixes some regressions introduced by previous patches. Works for me and
>>>> I haven't met any new regression or bug, ACK.
>>>>
>>>
>>>
>>
>>
>
> Thanks for the catch, Martin. Now it's really fixed and can be pushed.
> Obligatory keyword to trigger the push: ACK

Thanks. Attaching the patches for reference.

Pushed to master: 0f995312565e69768c660b85476b1efe1f62fb84

>
> BTW, I've discovered other related issue [1] that is there since 4.2. I
> will send patch soon.
>
> [1] https://fedorahosted.org/freeipa/ticket/5945
>


-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-618-schema-do-not-validate-unrequested-params-in-command.patch
Type: text/x-patch
Size: 2161 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/184ab00c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-619-replica-install-use-remote-server-API-to-create-serv.patch
Type: text/x-patch
Size: 11200 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/184ab00c/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-620-schema-fix-topic-command-output.patch
Type: text/x-patch
Size: 2492 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/184ab00c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-621-schema-fix-typo.patch
Type: text/x-patch
Size: 933 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/184ab00c/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-622-spec-file-require-correct-packages-to-get-API-plugin.patch
Type: text/x-patch
Size: 2078 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/184ab00c/attachment-0004.bin>