[Freeipa-devel] [PATCH 0046] Don't fail in find/show methods if userCertificate is invalid

Petr Spacek pspacek at redhat.com
Fri Jun 10 10:28:34 UTC 2016


On 9.6.2016 15:07, Martin Basti wrote:
> 
> 
> On 09.06.2016 15:03, Martin Basti wrote:
>>
>>
>> On 09.06.2016 15:02, Stanislav Laznicka wrote:
>>> On 06/09/2016 02:51 PM, Rob Crittenden wrote:
>>>> Stanislav Laznicka wrote:
>>>>> Hello,
>>>>>
>>>>> Please see the attached patch of
>>>>> https://fedorahosted.org/freeipa/ticket/5797.
>>>>>
>>>>> Standa
>>>>>
>>>>>
>>>>>
>>>>
>>>> Just wondering out loud but should usercertificate be excluded from the
>>>> output if it is unparsable? Is there any value in showing that a bogus
>>>> value is in there?
>>>>
>>>> rob
>>> I think it is a good pointer that something has gone wrong with the
>>> certificate. Another way would be to print 'Invalid certificate' instead of
>>> it similar to what Apache LDAP Browser does.
>>>
>>
>> We can return a warning message that something with certificates is broken.
>>
>> Martin^2
>>
> And you should log it at error log level, because it is error

+1

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list