[Freeipa-devel] [PATCH 0135-0136] DNS: Warn about restart when default TTL setting DNS is change DNS: Support default TTL setting for master DNS zone

[Petr Spacek]

On 20.6.2016 18:05, Martin Basti wrote:
> 
> 
> On 20.06.2016 16:57, Petr Spacek wrote:
>> Hello,
>>
>> DNS: Warn about restart when default TTL setting DNS is changed
>>
>> bind-dyndb-ldap 10.0 has to be restarted after each change to default
>> TTL.
>>
>> https://fedorahosted.org/freeipa/ticket/2956
>>
>> DNS: Support default TTL setting for master DNS zones
>>
>> https://fedorahosted.org/freeipa/ticket/2956
>>
>>
>>
> Thank you for patches, but I have a few comments
> 
> TTL patch:
> 1)
> VERSION - please put short note why API was incremented
> 
> 2)
> 60ipadns.ldif - please keep ordered attr definitions by OID
> 
> 3)
> You missed ACI for updating
> 
> Warning patch: LGTM

Thank you very much for review!

Here is revised version.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0135-2-DNS-Support-default-TTL-setting-for-master-DNS-zones.patch
Type: text/x-patch
Size: 13380 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160620/8c8503c8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0136-2-DNS-Warn-about-restart-when-default-TTL-setting-DNS-.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160620/8c8503c8/attachment-0001.bin>