[Freeipa-devel] [PATCH 0532] Fix possibly undefined variable

[Martin Basti]

On 20.06.2016 20:31, Alexander Bokovoy wrote:
> On Mon, 20 Jun 2016, Martin Basti wrote:
>> Patch attached.
>>
>
>> From a073b44587a5b34c4f1de5742d54e7c547cd5821 Mon Sep 17 00:00:00 2001
>> From: Martin Basti <mbasti at redhat.com>
>> Date: Mon, 20 Jun 2016 12:48:38 +0200
>> Subject: [PATCH] Fix possibly undefined variable in 
>> ipa_smb_conf_exists()
>>
>> There was missing else statement what may result in undefined conf_fd
>> variable.
>> ---
>> ipaserver/install/adtrustinstance.py | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/ipaserver/install/adtrustinstance.py 
>> b/ipaserver/install/adtrustinstance.py
>> index 
>> 94474122125a59d7da8b05a13dcd6c0f20568855..6ab15df27216580d440ce72386113d6872c046b2 
>> 100644
>> --- a/ipaserver/install/adtrustinstance.py
>> +++ b/ipaserver/install/adtrustinstance.py
>> @@ -81,6 +81,8 @@ def ipa_smb_conf_exists():
>>     except IOError as err:
>>         if err.errno == errno.ENOENT:
>>             return False
>> +        else:
>> +            raise
>>
>>     lines = conf_fd.readlines()
>>     conf_fd.close()
>> -- 
>> 2.5.5
>>
> ACK, thanks!
>
Thanks pushed to master
master:
* fe689e9938d6bcddd848f70b2f719253c55c09d7 Fix possibly undefined 
variable in ipa_smb_conf_exists()