[Freeipa-devel] [WIP] Thin client

[Jan Cholasta]

On 20.6.2016 19:56, Martin Basti wrote:
>
>
> On 20.06.2016 18:48, Martin Basti wrote:
>>
>>
>> On 20.06.2016 16:42, Jan Cholasta wrote:
>>> On 20.6.2016 16:13, David Kupka wrote:
>>>> On 28/04/16 14:45, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> I have pushed my thin client WIP branch to GitHub:
>>>>> <https://github.com/jcholast/freeipa/tree/trac-4739>.
>>>>>
>>>>> All commits up to "ipalib: use relative imports for cross-plugin
>>>>> imports" should be good for review. The rest is subject to change
>>>>> (WARNING: I will force push into this branch).
>>>>>
>>>>> Honza
>>>>>
>>>>
>>>> Hello!
>>>>
>>>> Patches:
>>>> replica install: fix thin client regression
>>>> schema: remove `no_cli` from command schema
>>>> schema: remove redundant information
>>>> schema: merge command args and options
>>>> schema: remove output_params
>>>> schema: add object class schema
>>>> permission: handle ipapermright deprecated CLI alias on the client
>>>> passwd: handle sort order of passwd argument on the client
>>>> misc: skip `count` and `total` output in env.output_for_cli
>>>> dns: do not rely on custom param fields in record attributes
>>>> automember: add object plugin for automember_rebuild
>>>> frontend: do not crash on missing output in output_for_cli
>>>> frontend: skip `value` output in output_for_cli
>>>> frontend: don't copy command arguments to output params
>>>> makeaci, makeapi: use in-server API
>>>>
>>>> work for me, ACK.
>>>
>>> Pushed to master: 8cc8b6fb1023fa4aeafac0df01cfacff4ebf537a
>>>
>>> Note that I haven't pushed "replica install: fix thin client
>>> regression" yet, I would like Martin to review it first.
>>
>> ACK
>>
>> pushed to master:
>> * 91d6d87ca76e3aa27d5f87fd4f0b70f1d4fe4e72 replica install: fix thin
>> client regression
>>
>>>
>>> Attaching the patches for reference.
>>>
>>>>
>>>> Note: There is one one known issue in automember output, will be fixed
>>>> later.
>>>
>>>
>>
>>
>>
> Guys, I suspect that one of previously pushed patches breaks following
> command on the client side
>
> # ipa dns-update-system-records
> ipa: ERROR: KeyError: 'ipa_records'
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/ipalib/cli.py", line 1346, in run
>     sys.exit(api.Backend.cli.run(argv))
>   File "/usr/lib/python2.7/site-packages/ipalib/cli.py", line 1111, in run
>     rv = cmd.output_for_cli(self.api.Backend.textui, result, *args,
> **options)
>   File "/usr/lib/python2.7/site-packages/ipaclient/plugins/dns.py", line
> 367, in output_for_cli
>     textui.print_indented(u'{}:'.format(labels[key]), indent=1)
> KeyError: 'ipa_records'
> ipa: ERROR: an internal error has occurred

Sorry. Fixed.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-649-dns-fix-dns_update_system_records-to-work-with-thin-.patch
Type: text/x-patch
Size: 3963 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160621/df897793/attachment.bin>