[Freeipa-devel] [PATCH] Schema caching for thin client

[Jan Cholasta]

On 16.6.2016 09:12, David Kupka wrote:
> On 06/15/2016 08:15 PM, Petr Vobornik wrote:
>> On 06/15/2016 02:36 PM, David Kupka wrote:
>>> Hello!
>>> Schema caching for thin client is available here:
>>>
>>> https://github.com/dkupka/freeipa/commits/schema_cache
>>>
>>> Comments and reviews welcome.
>>>
>>> Enjoy!
>>
>> Not doing proper review. I'll test by using it. But:
>>
>> 1. lint fails
>>
>> Pylint is running, please wait ...
>> ************* Module ipaclient.remote_plugins.schema_cache
>> ipaclient/remote_plugins/schema_cache.py:283: [W1612(unicode-builtin),
>> _refresh_schema] unicode built-in referenced)
>> Makefile:137: recipe for target 'lint' failed
>> make: *** [lint] Error 1
>>
>> I.e, you miss:
>>
>>   import six
>>
>>   if six.PY3:
>>       unicode = str
>>
>
> Thanks for the catch, fixed version force-pushed.

ACK on the server part, i.e. the first 3 commits:

0cd99a7 schema: Cache schema in api instance
b9a58c4 schema: Add known_fingerprints option to schema command
f6f4e53 schema: Add fingerprint and TTL

Pushed to master: d0e708cba240bd92a4467495caeb654eff6ae69a

-- 
Jan Cholasta