[Freeipa-devel] [PATCH] 0077 Check for CA subject name collision before attempting creation

[Fraser Tweedale]

Hi,

Attached patch fixes https://fedorahosted.org/freeipa/ticket/5981.

Cheers,
Fraser
-------------- next part --------------
From 905bef9ca787cea6ae66e2dbe3df33a2420bbd8b Mon Sep 17 00:00:00 2001
From: Fraser Tweedale <ftweedal at redhat.com>
Date: Fri, 24 Jun 2016 17:29:51 +1000
Subject: [PATCH] Check for CA subject name collision before attempting
 creation

Lightweight CA subject name collisions are prevented by Dogtag
(response code 409 Conflict), however, we do not want to expose the
Dogtag error.  Perform the check in the IPA framework as well,
raising DuplicateEntry on collision.

Fixes: https://fedorahosted.org/freeipa/ticket/5981
---
 ipaserver/plugins/ca.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ipaserver/plugins/ca.py b/ipaserver/plugins/ca.py
index ee98f0a2a9dc469d67676a3123d82ce519ba6d59..966ae2b1bdb4bb0207dfa58f0e9c951bc930f766 100644
--- a/ipaserver/plugins/ca.py
+++ b/ipaserver/plugins/ca.py
@@ -163,6 +163,13 @@ class ca_add(LDAPCreate):
         except errors.NotFound:
             pass
 
+        # check for subject collision before creating CA in Dogtag
+        result = api.Command.ca_find(ipacasubjectdn=options['ipacasubjectdn'])
+        if result['count'] > 0:
+            raise errors.DuplicateEntry(message=_(
+                "Subject DN is already used by CA '%s'"
+                ) % result['result'][0]['cn'][0])
+
         # Create the CA in Dogtag.
         with self.api.Backend.ra_lightweight_ca as ca_api:
             resp = ca_api.create_ca(options['ipacasubjectdn'])
-- 
2.5.5