[Freeipa-devel] [PATCH 0050-0051] Topology fixes for CA suffix

Martin Babinsky mbabinsk at redhat.com
Fri Jun 24 09:52:52 UTC 2016


On 06/24/2016 11:30 AM, Petr Vobornik wrote:
> On 06/23/2016 05:30 PM, Stanislav Laznicka wrote:
>> On 06/23/2016 04:38 PM, Petr Vobornik wrote:
>>> On 06/23/2016 04:20 PM, Stanislav Laznicka wrote:
>>>> Hello,
>>>>
>>>> attached are patches fixing the logic mentioned in
>>>> https://fedorahosted.org/freeipa/ticket/5967.
>>>>
>>>>
>>> If server supports the suffix can be verified in validate_nodes call
>>> where masters are already fetched.
>>>
>> Thank you for the suggestion, modified patch 50 attached.
>>
>
> Maybe it's just me, but the code is hard to ready. Check the attached
> version - speeding up review process.
>
> I've also change the first commit message line it was too generic.
>
>
>

If you intend to use that internal function in other modules, please 
remove the leading underscore from its name. Otherwise pylint/IDEs may 
complain about import of private module member.

-- 
Martin^3 Babinsky




More information about the Freeipa-devel mailing list