[Freeipa-devel] [PATCH] 0058 WebUI: certificate widget on ID override user page

[Pavel Vomacka]

On 06/23/2016 04:25 PM, Petr Vobornik wrote:
> On 06/20/2016 06:54 PM, Pavel Vomacka wrote:
>> Hello,
>>
>> please review attached patch.
>>
>> https://fedorahosted.org/freeipa/ticket/5926
>>
> 1. I'm not sure whether to include the certificate field in the adder
> dialog. But if so then it is not good that it accepts different output
> then a cert widget. The difference is that cert widget is able to work
> also with "-----BEGIN CERTIFICATE-----" and "-----END CERTIFICATE-----"
> values.
Oh, you are right, I forgot to add custom widget which handles that. 
Fixed now.
>
> Otherwise it works good.
>
> If we decided not to fix 1. in this patch then ACK.
>
> Push should wait on the other cert patches.
>
Updated patch attached.

-- 
Pavel^3 Vomacka

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0058-2-Add-certificate-widget-to-ID-override-user-details-p.patch
Type: text/x-patch
Size: 7120 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160627/fdbaea1e/attachment.bin>