[Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

[Pavel Vomacka]

On 06/23/2016 04:58 PM, Petr Vobornik wrote:
> On 06/23/2016 04:34 PM, Martin Basti wrote:
>>
>> On 23.06.2016 09:57, Pavel Vomacka wrote:
>>> Hello,
>>>
>>> please review attached patch.
>>>
>>> Part of: https://fedorahosted.org/freeipa/ticket/5905
>>>
>>>
>>>
>> Works for me
>>
> In this patch and also in some other(cert patches) the confirm message
> has following structure:
>    To confirm your intention to $action, click the $button_name button.
>
> On other places of Web UI, more human and easier structure is used:
>    Do you want to update DNS records?
>    [Update] [Cancel]
>
> IMHO we should use it here as well. And the same for(separate path):
>    remove_certificate_hold_confirmation
>    revoke_confirmation"
>
>
> otherwise the patch is OK.
>
The patch with simplified confirm message is attached. Patch with new 
'remove cert hold' and 'revoke cert' messages will be sent in separate 
thread.

-- 
Pavel^3 Vomacka

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0061-2-Add-button-for-dns_update_system_records-command.patch
Type: text/x-patch
Size: 4216 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160627/56ceba0f/attachment.bin>