[Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

[Petr Vobornik]

On 06/28/2016 05:38 PM, Pavel Vomacka wrote:
> 
> 
> On 06/28/2016 03:12 PM, Petr Spacek wrote:
>> On 27.6.2016 17:48, Pavel Vomacka wrote:
>>>
>>> On 06/23/2016 04:58 PM, Petr Vobornik wrote:
>>>> On 06/23/2016 04:34 PM, Martin Basti wrote:
>>>>> On 23.06.2016 09:57, Pavel Vomacka wrote:
>>>>>> Hello,
>>>>>>
>>>>>> please review attached patch.
>>>>>>
>>>>>> Part of: https://fedorahosted.org/freeipa/ticket/5905
>>>>>>
>>>>>>
>>>>>>
>>>>> Works for me
>>>>>
>>>> In this patch and also in some other(cert patches) the confirm message
>>>> has following structure:
>>>>     To confirm your intention to $action, click the $button_name
>>>> button.
>>>>
>>>> On other places of Web UI, more human and easier structure is used:
>>>>     Do you want to update DNS records?
>>>>     [Update] [Cancel]
>>>>
>>>> IMHO we should use it here as well. And the same for(separate path):
>>>>     remove_certificate_hold_confirmation
>>>>     revoke_confirmation"
>>>>
>>>>
>>>> otherwise the patch is OK.
>> The patch works!
>>
>> Nitpick: 'Update DNS records' is too generic. The button and message
>> should
>> contain keyword 'system' somewhere.
>>
>> E.g. 'Update system DNS records'. Feel free to push it when you add the
>> keyword :-)
>>
> 
> Thank you for review.
> 
> Strings updated.
> 

ACK

-- 
Petr Vobornik