[Freeipa-devel] [PATCH 0025][Tests] RFE: External trust

[Lenka Doudova]

On 06/30/2016 04:12 PM, Oleg Fayans wrote:
> Hi Lenka,
>
> The changes in test_trust.py are fine.
> As for tasks.py:
> 1. I'd rename sync_time_hostname to just sync_time and
There's already one sync_time function with different contents, it 
seemed nicer to create a new function than adding some "switch" into the 
old one, making it three time longer.
> 2. I would start ntpd again in the same method: it's no good to keep
> this thing in mind each time you call it.
Leaving ntpd stopped is "legacy" from original function, and as I am not 
sure which purpose it serves, I decided to leave it as it is.
>
> Besides, I would split the changes into 2 patches: one for tasks.py and
> other for test_trust.py
No problem there, + adding ticket info into commit message, as I seem to 
have forgot again.
>
>
> On 06/30/2016 03:47 PM, Lenka Doudova wrote:
>> Hi,
>>
>> attaching patch with some basic coverage for external trust feature. Bit
>> more detailed info in commit message.
>>
>> Since the feature requires me to run commands previously used only for
>> forest root domains even for subdomains, I made some changes in
>> ipatests/test_integration/tasks.py file, so that it would enable me to
>> reuse existing function without copy-pasting them for one variable change.
>>
>>
>> Lenka
>>
>>
>>