[Freeipa-devel] [PATCH 0427] fix broken configuration of sidgen and extdom plugins

[Martin Basti]

On 01.03.2016 17:14, Martin Basti wrote:
>
>
> On 01.03.2016 17:13, Petr Vobornik wrote:
>> On 03/01/2016 05:02 PM, Martin Basti wrote:
>>>
>>>
>>> On 01.03.2016 16:39, Petr Vobornik wrote:
>>>> On 02/23/2016 06:15 PM, Martin Basti wrote:
>>>>>
>>>>>
>>>>> On 23.02.2016 17:31, Tomas Babej wrote:
>>>>>>
>>>>>> On 02/23/2016 01:25 PM, Martin Basti wrote:
>>>>>>>
>>>>>>> On 23.02.2016 13:02, Alexander Bokovoy wrote:
>>>>>>>> On Tue, 23 Feb 2016, Martin Basti wrote:
>>>>>>>>>  From f2ae1bd129a1741500d2f3dcb86a0da553604d15 Mon Sep 17 
>>>>>>>>> 00:00:00
>>>>>>>>> 2001
>>>>>>>>> From: Martin Basti <mbasti at redhat.com>
>>>>>>>>> Date: Tue, 23 Feb 2016 10:37:47 +0100
>>>>>>>>> Subject: [PATCH 4/4] fix upgrade: wait for proper DS socket 
>>>>>>>>> after DS
>>>>>>>>> restart
>>>>>>>>>
>>>>>>>>> Restarting DS executed by upgrade plugin causes that upgrade
>>>>>>>>> frameworg
>>>>>>>>> was waiting for not proper socket to be ready. This commit fix
>>>>>>>>> issue.
>>>>>>>> Please fix the commit message typos.
>>>>>>>>
>>>>>>> Fixed. Updated patches attached.
>>>>>> ACK.
>>>>>>
>>>>>> Tomas
>>>>> Pushed to master: 0accf8ccb64963954dbe7c137d23f52e5901ac4f
>>>>> Pushed to ipa-4-3: 4734012c8063460f93f3b819a5bbcca797f6059e
>>>>> Pushed to ipa-4-2: 63d8caf0d105f02decc0b5d865fedf6ad063bc1a
>>>>>
>>>>
>>>> Testing freeipa-4.2.4 build and it fails at
>>>> install/dsinstance.py:add_sidgen_plugin:936
>>>>
>>>> adding self.ldap_connect() on line 937 fixed the issue.
>>>
>>> Well I may rework PATCH 0416, and fix it in different way, or I can add
>>> self.ldap_connect() to sidgen and extdom steps.
>>>
>>> Which is better?
>>>
>>
>> I would avoid reworking it in all 3 branches if in 4.3 and master it 
>> works and is actually correct. Doesn't make sense to change new code 
>> because of missing features in old branches. Adding connect to 
>> ipa-4-2 seems enough to me.
>
> IMO it works accidentaly there, any additional patch or restart can 
> break it in 4.3 and master too
>
Patch attached.

ipa-4-2 needs to have backported ca8f63624b204f0c4f2d1ac5f4ed93551f7e62df
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0427-Fix-connections-to-DS-during-installation.patch
Type: text/x-patch
Size: 1407 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160301/bb082e36/attachment.bin>