[Freeipa-devel] [PATCH] 0007 webui: Add a field for GID in the user add dialog

[Pavel Vomacka]

On 03/04/2016 07:03 PM, Petr Vobornik wrote:
> On 03/01/2016 01:37 PM, Pavel Vomacka wrote:
>> Hi,
>>
>> The patch adds new field in user add dialog. This combo box lists GIDs
>> of posix groups
>> so user can choose one. It is also possible to fill a GID number
>> which is not in the list.
>>
>> Link to the ticket: https://fedorahosted.org/freeipa/ticket/5505
>>
>> -- 
>> Pavel^3 Vomacka
>>
>
> 1. We can keep default label 'GID' by removing 'label' from spec, 
> which is also used on details page. No need to add a new string.
>
> 2. It is hard to pick a group from a list because the only thing 
> administrator see are GID numbers, e.g.,:
>   * 330800000
>   * 330800002
>
> It would be good to show a group name there or group name + GID
>   * admins
>   * editors
>
> Reasoning:
> a) If admin wants to set arbitrary GID number not manage in IPA, he 
> already knows it and can enter it directly.
> b) If he want's to set a specific group then he will search for it by 
> name.
>
> Such change will require a change in combobox widget so that we can 
> specify a label field and a value field. E.g. list will operate with  
> e.g.:
> [
>    { label: 'admins', value: 330800000 },
>    { label: 'editors', value: 330800000 }
> ]
>
> and not [ 330800000, 330800000 ]
>
> I tried if it is possible to do easily and yes. See attached wippatch. 
> Would be good to check if it breaks anything. If not then we can merge 
> it into your patch.
Hi,

thank you for your patch. It's definitely better to see names of groups 
instead of numbers. Your solution works well.

I merged your patch with mine and the result is attached. I also removed 
definitions of new string (was used as label) from my first patch .

Pavel^3 Vomacka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0007-2-Add-field-for-group-id-in-user-add-dialog.patch
Type: text/x-patch
Size: 2602 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160307/568a9afe/attachment.bin>