[Freeipa-devel] [PATCH] BUILD: Remove detection of libcheck

Lukas Slebodnik lslebodn at redhat.com
Thu Mar 10 09:40:14 UTC 2016


ehlo,

simple patch is attached.

LS
-------------- next part --------------
>From 2b34cdbb3b36dcf95746fdf3d843f66989b0f1c0 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 10 Mar 2016 10:26:52 +0100
Subject: [PATCH] BUILD: Remove detection of libcheck

The unit test framework check has not been used in freeipa for long time
(if ever) but there was still conditional check for this framework.
It just produced confusing warning:
    Without the 'CHECK' library, you will be unable
    to run all tests in the 'make check' suite
---
 BUILD.txt            |  2 +-
 daemons/configure.ac | 11 -----------
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/BUILD.txt b/BUILD.txt
index d948495..b5660aa 100644
--- a/BUILD.txt
+++ b/BUILD.txt
@@ -23,7 +23,7 @@ autoconf automake m4 libtool gettext python-devel python-ldap \
 python-setuptools python-nss python-netaddr python-gssapi \
 python-rhsm pyOpenSSL pylint python-polib libipa_hbac-python python-memcached \
 sssd python-lxml python-pyasn1 python-qrcode-core python-dns m2crypto \
-check libsss_idmap-devel libsss_nss_idmap-devel java-headless rhino \
+libsss_idmap-devel libsss_nss_idmap-devel java-headless rhino \
 libverto-devel systemd libunistring-devel python-lesscpy python-yubico \
 python-backports-ssl_match_hostname softhsm-devel openssl-devel \
 p11-kit-devel pki-base python-pytest-multihost python-pytest-sourceorder
diff --git a/daemons/configure.ac b/daemons/configure.ac
index 2a1f6aa..2906def 100644
--- a/daemons/configure.ac
+++ b/daemons/configure.ac
@@ -208,17 +208,6 @@ dnl ---------------------------------------------------------------------------
 PKG_CHECK_MODULES([LIBVERTO], [libverto])
 
 dnl ---------------------------------------------------------------------------
-dnl - Check for check unit test framework http://check.sourceforge.net/
-dnl ---------------------------------------------------------------------------
-PKG_CHECK_MODULES([CHECK], [check >= 0.9.5], [have_check=1], [have_check=])
-if test x$have_check = x; then
-    AC_MSG_WARN([Without the 'CHECK' library, you will be unable to run all tests in the 'make check' suite])
-else
-    AC_CHECK_HEADERS([check.h],,AC_MSG_ERROR([Could not find CHECK headers]))
-fi
-AM_CONDITIONAL([HAVE_CHECK], [test x$have_check != x])
-
-dnl ---------------------------------------------------------------------------
 dnl - Check for cmocka unit test framework http://cmocka.cryptomilk.org/
 dnl ---------------------------------------------------------------------------
 PKG_CHECK_EXISTS(cmocka,
-- 
2.7.2



More information about the Freeipa-devel mailing list