[Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

[Petr Vobornik]

On 03/08/2016 01:17 PM, Lenka Doudova wrote:
>
>
> On 03/08/2016 12:59 PM, Petr Vobornik wrote:
>> On 03/07/2016 04:29 PM, Pavel Vomacka wrote:
>>>
>>>
>>> On 02/25/2016 03:08 PM, Lenka Doudova wrote:
>>>> Hi,
>>>>
>>>> here's a patch for webUI tests that provides test for creating user
>>>> without private group.
>>>> Related to ticket https://fedorahosted.org/freeipa/ticket/4986
>>>>
>>>> Since the option to specify GID when creating a user is not available
>>>> https://fedorahosted.org/freeipa/ticket/5505 the test creates a new
>>>> posix group, makes it a default user group instead of 'ipausers' and
>>>> then attemps to create the user without private group. Returning
>>>> default user group value to 'ipausers' is provided even for cases when
>>>> the test fails so it would not block other tests from performing
>>>> properly.
>>>>
>>>> Lenka
>>>>
>>>>
>>> Hi,
>>>
>>> ACK, works well.
>>>
>>> Pavel^3 Vomacka
>>>
>>
>> NACK, don't use naked except, specify at least 'Exception'
>>   +        except:
>>
>
> Thanks, patch fixed according to Petr's review attached.
>
> Lenka

Ticket 5505 was pushed. So the workaround can be removed. Do you prefer 
to do it in this patch?

Also, maybe it would be good to test both cases and check if the error 
is actually the right one.
-- 
Petr Vobornik