[Freeipa-devel] [PATCH 0024] ipa-replica-manage: added --suffix option for certain commands

[Jan Cholasta]

On 14.3.2016 12:50, Martin Basti wrote:
>
>
> On 14.03.2016 12:05, Jan Cholasta wrote:
>> Hi,
>>
>> On 11.3.2016 10:39, Stanislav Laznicka wrote:
>>> Hi,
>>>
>>> Please see the patch attached. Contrary to the discussion at
>>> https://fedorahosted.org/freeipa/ticket/4987 I also added the suffix
>>> option for clean_ruv command. If this command is available for normal
>>> RUVs, it should probably be available for CS-RUVs as well (or deprecated
>>> for both with advised use of clean_dangling_ruv).
>>
>> ipa-csreplica-manage is used to manage the CA suffix, so
>> ipa-csreplica-manage should be extended instead of adding --suffix
>> option to ipa-replica-manage. Having half of the CA suffix managed by
>> ipa-replica-manage and the other half by ipa-replica-manage is confusing.
>>
>> Honza
>>
> There is a design document about deprecating ipa-csreplica-manage and
> move part of its responsibilities to ipa-replica-manage.
>
> http://www.freeipa.org/page/V4/Manage_replication_topology_4_4#ipa.28cs.29replica_manange_changes
>
>
> So patch is compatible with design.

The design is wrong then.

Either do it in ipa-csreplica-manage, or make *all* ipa-replica-manage 
sub-commands respect the --suffix option. Anything else is inconsistent 
mess.

-- 
Jan Cholasta