[Freeipa-devel] [PATCH 537] ipapython: port p11helper C code to Python

[Martin Basti]

On 18.03.2016 08:45, Timo Aaltonen wrote:
> 18.03.2016, 09:45, Jan Cholasta kirjoitti:
>> On 18.3.2016 05:16, Timo Aaltonen wrote:
>>> 07.01.2016, 10:50, Jan Cholasta kirjoitti:
>>>> Hi,
>>>>
>>>> the attached patch ports the _ipap11helper module to python-cffi.
>>>>
>>>> Combined with my patch 536 [1], this makes ipapython architecture
>>>> independent.
>>> don't know why it works for you, but ipa-ods-exporter and
>>> ipa-dnskeysync-replica both still try to import _ipap11helper, which
>>> fails:
>>>
>>> maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]: Traceback
>>> (most recent call last):
>>> maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]:   File
>>> "/usr/lib/ipa/ipa-ods-exporter", line 4
>>> maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]:     import
>>> _ipap11helper
>>> maalis 18 05:45:46 trusty.tyrell ipa-ods-exporter[8788]: ImportError:
>>> No module named _ipap11helper
>>> maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service:
>>> Main process exited, code=exited
>>> maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service:
>>> Unit entered failed state.
>>> maalis 18 05:45:46 trusty.tyrell systemd[1]: ipa-ods-exporter.service:
>>> Failed with result 'exit-code'.
>>> maalis 18 05:46:47 trusty.tyrell systemd[1]: ipa-ods-exporter.service:
>>> Service hold-off time over, sche
>>> maalis 18 05:46:47 trusty.tyrell systemd[1]: Stopped IPA OpenDNSSEC
>>> Signer replacement.
>>>
>>> dropping the import makes it work again here.. this is with fairly
>>> current ipa-4-3 branch.
>> Patch attached.
>>
>> Pylint does not detect this obvious error for some reason.
> can't beat git grep :)
>
> I've tested with essentially the same patch, so it works.
>
>
ACK
Pushed to ipa-4-3: 212c4cb671bec5a3d6fe320284136c87a81228ae