[Freeipa-devel] [PATCH] Added fix for notifying user about account expiration in Web UI

[Abhijeet Kasurde]

Hi All,

Please find the updated patches as per review comments.

On 03/18/2016 07:39 PM, Petr Vobornik wrote:
> On 03/18/2016 02:21 PM, Abhijeet Kasurde wrote:
>> Hi All,
>>
>> Please review these patches.
>>
>> Fixes : https://fedorahosted.org/freeipa/ticket/5077
>>
>> Thanks,
>> Abhijeet Kasurde
>>
>
> 'invalid' is a default and right now is meant for invalid password(not 
> correct, see below). So by reading the patch, it will break the case 
> when user sets invalid password.
>
> Better would be to process kinit output in rpcserver.py:login_password 
> and set e.g: 'krbprincipal-expired' reason.
>
> Then add it to a list of known errors in ipa.js:login_password:498. We 
> should probaly add also 'invalid-password' to the list.
>
> Then do the change as in this patch but only with: 
> 'krbprincipal-expired'.
>
> If 'invalid-password' is added to the list of know errors then we 
> should change the default error from "The password or username you 
> entered is incorrect. " to e.g.: 'Login failed from unknown reason"
>
Thanks Petr for suggestions.

Thanks,
Abhijeet Kasurde
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akasurde-0006-2-Added-fix-for-notifying-user-about-Kerberos-principa.patch
Type: text/x-patch
Size: 7187 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160322/2fad2197/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akasurde-0006-2-Added-fix-for-notifying-user-about-Kerberos-principa-ipa-4-2.patch
Type: text/x-patch
Size: 7233 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160322/2fad2197/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akasurde-0006-2-Added-fix-for-notifying-user-about-Kerberos-principa-ipa-4-3.patch
Type: text/x-patch
Size: 7233 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160322/2fad2197/attachment-0002.bin>