[Freeipa-devel] [PATCH 0012-0013] Improve ipaplatform.constants

David Kupka dkupka at redhat.com
Wed Mar 23 12:14:16 UTC 2016


On 23/03/16 07:17, Timo Aaltonen wrote:
> 22.03.2016, 21:10, Timo Aaltonen kirjoitti:
>> 18.03.2016, 12:30, Timo Aaltonen kirjoitti:
>>>
>>> Fix some hardcoded uid/gid strings to help with porting.
>>
>> rebased and simplified against current master.
>
> bah, the second patch needs to use constants.{ODS_USER,ODS_GROUP} now.
>
>
Hello, thanks for the patches. I've done few minor changes:
- using constants.ODS_{USER,GROUP} in second patch as you've mentioned
- added ticket URL to commit messages for future reference
- rebased the first patch to ipa-4-3 branch

Now it works for me, ACK.

-- 
David Kupka

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tjaalton-0012.1-43-ipaplatform-Move-remaining-user-group-constants-to-i.patch
Type: text/x-patch
Size: 13715 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160323/05bcb7b0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tjaalton-0012.1-ipaplatform-Move-remaining-user-group-constants-to-i.patch
Type: text/x-patch
Size: 13740 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160323/05bcb7b0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tjaalton-0013.1-Use-ODS_USER-ODS_GROUP-in-opendnssec_conf.template.patch
Type: text/x-patch
Size: 1623 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160323/05bcb7b0/attachment-0002.bin>


More information about the Freeipa-devel mailing list