[Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way

[Peter Lacko]

Hi!

Thanks for the review, should be OK now. I won't change this email's subject, so adding it to the body only and will include it in subject of next patch.

[PATCH 0001]

Regards,

Peter Lacko


----- Original Message -----
From: "Martin Basti" <mbasti at redhat.com>
To: "Peter Lacko" <placko at redhat.com>, freeipa-devel at redhat.com
Sent: Thursday, April 28, 2016 4:09:17 PM
Subject: Re: [Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way



On 08.04.2016 10:32, Peter Lacko wrote:
>
>

Hello,

I have a few comments:

1)
Please set up your git name and email correctly (consistently for all 
patches)

this is not right From: root<root at vm-058-184.abc.idm.lab.eng.brq.redhat.com>

2)
-# Copyright (C) 2012  Red Hat
+# Copyright (C) 2016  Red Hat

leave there both years please
+# Copyright (C) 2012, 2016  Red Hat

3)
Please put the patch number to the email subject, it is easier to find correct patch for us

Otherwise LGTM and works for me.

Martin^2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-placko-0001-2-Ping-module-tests.patch
Type: text/x-patch
Size: 2966 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160504/c924686a/attachment.bin>